[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a64ed431-0f60-2711-4138-eeefc7ba2d8b@arm.com>
Date: Wed, 16 May 2018 11:56:26 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Andy Shevchenko <andy.shevchenko@...il.com>,
Jeremy Linton <jeremy.linton@....com>
Cc: Sudeep Holla <sudeep.holla@....com>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
Hanjun Guo <hanjun.guo@...aro.org>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Will Deacon <Will.Deacon@....com>,
Catalin Marinas <Catalin.Marinas@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Mark Rutland <Mark.Rutland@....com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-riscv@...ts.infradead.org,
Xiongfeng Wang <wangxiongfeng2@...wei.com>,
vkilari@...eaurora.org, Al Stone <ahs3@...hat.com>,
Dietmar.Eggemann@....com, Morten.Rasmussen@....com,
Palmer Dabbelt <palmer@...ive.com>,
Len Brown <lenb@...nel.org>,
John Garry <john.garry@...wei.com>, austinwc@...eaurora.org,
tnowicki@...iumnetworks.com, jhugo@...eaurora.org,
Ard Biesheuvel <ard.biesheuvel@...aro.org>
Subject: Re: [PATCH v9 02/12] drivers: base: cacheinfo: setup DT cache
properties early
Hi Andy,
On 15/05/18 20:32, Andy Shevchenko wrote:
> On Tue, May 15, 2018 at 8:15 PM, Jeremy Linton <jeremy.linton@....com> wrote:
>> On 05/11/2018 06:57 PM, Jeremy Linton wrote:
>
>>> - cache_size = of_get_property(this_leaf->of_node, propname, NULL);
>>> + cache_size = of_get_property(np, propname, NULL);
>>> if (cache_size)
>>> this_leaf->size = of_read_number(cache_size, 1);
>
> Can't you switch to of_read_property_uXX() variant here?
>
This patch is just changing the first argument to the calls. So if we
need to change, it has to be separate patch.
Now, we can use of_property_read_u64() but is there any particular
reason you mention that ? One reason I can see is that we can avoid
making explicit of_get_property call. Just wanted to the motive before I
can write the patch.
--
Regards,
Sudeep
Powered by blists - more mailing lists