[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dc6f6d01-7ca5-5264-6a58-1d5327da08cb@cogentembedded.com>
Date: Wed, 16 May 2018 14:42:53 +0300
From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To: Tiwei Bie <tiwei.bie@...el.com>
Cc: mst@...hat.com, jasowang@...hat.com,
virtualization@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
wexu@...hat.com, jfreimann@...hat.com
Subject: Re: [RFC v4 5/5] virtio_ring: enable packed ring
On 05/16/2018 01:21 PM, Tiwei Bie wrote:
>>> Signed-off-by: Tiwei Bie <tiwei.bie@...el.com>
>>> ---
>>> drivers/virtio/virtio_ring.c | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>>> index de3839f3621a..b158692263b0 100644
>>> --- a/drivers/virtio/virtio_ring.c
>>> +++ b/drivers/virtio/virtio_ring.c
>>> @@ -1940,6 +1940,8 @@ void vring_transport_features(struct virtio_device *vdev)
>>> break;
>>> case VIRTIO_F_IOMMU_PLATFORM:
>>> break;
>>> + case VIRTIO_F_RING_PACKED:
>>> + break;
>>
>> Why not just add this *case* under the previous *case*?
>
> Do you mean fallthrough? Something like:
>
> case VIRTIO_F_IOMMU_PLATFORM:
> case VIRTIO_F_RING_PACKED:
> break;
Yes, exactly. :-)
> Best regards,
> Tiwei Bie
[...]
MBR, Sergei
Powered by blists - more mailing lists