[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b49cf013-79ca-3ad3-14e2-9227fde5b080@geekplace.eu>
Date: Wed, 16 May 2018 14:09:54 +0200
From: Florian Schmaus <flo@...kplace.eu>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] driver-core: print bus registration error value
On 16.05.2018 14:05, Florian Schmaus wrote:
> Signed-off-by: Florian Schmaus <flo@...kplace.eu>
> ---
>
> Notes:
> - Use correct member name 'bus_register_error'
> - Only print out error code if it is non-zero
>
> drivers/base/bus.c | 4 +++-
> drivers/base/driver.c | 13 ++++++++++---
> 2 files changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> index dce677dddba4..5814ecb07648 100644
> --- a/drivers/base/bus.c
> +++ b/drivers/base/bus.c
> @@ -849,8 +849,10 @@ int bus_register(struct bus_type *bus)
> struct lock_class_key *key = &bus->lock_key;
>
> priv = kzalloc(sizeof(struct subsys_private), GFP_KERNEL);
> - if (!priv)
> + if (!priv) {
> + bus->bus_register_error = -ENOMEM;
> return -ENOMEM;
> + }
>
> priv->bus = bus;
> bus->p = priv;
I'm sorry, this change was meant to be part of 2/3 (and not 3/3). Shall
I send a v5 where this is fixed?
- Florian
Download attachment "signature.asc" of type "application/pgp-signature" (619 bytes)
Powered by blists - more mailing lists