linux-kernel - INTMS/INTMC not being used in NVME interrupt handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLUPR0201MB1505371050ED798BE025132BA5920@BLUPR0201MB1505.namprd02.prod.outlook.com>
Date:   Wed, 16 May 2018 12:35:15 +0000
From:   Bharat Kumar Gogada <bharatku@...inx.com>
To:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "keith.busch@...el.com" <keith.busch@...el.com>,
        "axboe@...com" <axboe@...com>, "hch@....de" <hch@....de>,
        "sagi@...mberg.me" <sagi@...mberg.me>
Subject: INTMS/INTMC not being used in NVME interrupt handling

Hi,

As per NVME specification: 
7.5.1.1 Host Software Interrupt Handling
It is recommended that host software utilize the Interrupt Mask Set and Interrupt Mask Clear (INTMS/INTMC) 
registers to efficiently handle interrupts when configured to use pin based or MSI messages.

In kernel 4.14, drivers/nvme/host/pci.c function nvme_isr 
doesn't  use these registers. 

Any reason why these registers are not used in nvme interrupt handler ?

Why NVMe driver is not using any bottom half and processing all completion queues
in interrupt handler ?

Regards,
Bharat