linux-kernel - Re: [PATCH V1 00/19] perf tools and x86 PTI entry trampolines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516125042.GA507@krava>
Date:   Wed, 16 May 2018 14:50:42 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Andi Kleen <ak@...ux.intel.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [PATCH V1 00/19] perf tools and x86 PTI entry trampolines

On Tue, May 15, 2018 at 03:43:14PM +0300, Adrian Hunter wrote:

SNIP

> 
>  # Overhead  Command    Shared Object     Symbol
>  # ........  .........  ................  ..................................
>  #
>     41.91%  uname_x_n  [kernel.vmlinux]  [k] syscall_return_via_sysret
>     24.70%  uname_x_n  [kernel.vmlinux]  [k] entry_SYSCALL_64_trampoline
>     19.22%  uname_x_n  [kernel.vmlinux]  [k] copy_user_enhanced_fast_string
>      4.09%  uname_x_n  libc-2.19.so      [.] __GI___uname
>      3.08%  uname_x_n  [kernel.vmlinux]  [k] do_syscall_64
>      2.32%  uname_x_n  [kernel.vmlinux]  [k] down_read
>      2.27%  uname_x_n  ld-2.19.so        [.] _dl_start
>      1.25%  uname_x_n  [kernel.vmlinux]  [k] up_read
>      0.99%  uname_x_n  [kernel.vmlinux]  [k] entry_SYSCALL_64
>      0.16%  uname_x_n  [kernel.vmlinux]  [k] flush_signal_handlers
>      0.01%  perf       [kernel.vmlinux]  [k] native_sched_clock
>      0.00%  perf       [kernel.vmlinux]  [k] native_write_msr
> 
> 
> Adrian Hunter (17):
>       kallsyms: Simplify update_iter_mod()
>       x86: kcore: Give entry trampolines all the same offset in kcore
>       perf tools: Use the _stest symbol to identify the kernel map when loading kcore
>       perf tools: Fix kernel_start for PTI on x86
>       perf tools: Workaround missing maps for x86 PTI entry trampolines
>       perf tools: Fix map_groups__split_kallsyms() for entry trampoline symbols
>       perf tools: Allow for extra kernel maps
>       perf tools: Create maps for x86 PTI entry trampolines
>       perf tools: Synthesize and process mmap events for x86 PTI entry trampolines

the perf tools patches look good to me:

    Acked-and-tested-by: Jiri Olsa <jolsa@...nel.org>

jirka

>       perf buildid-cache: kcore_copy: Keep phdr data in a list
>       perf buildid-cache: kcore_copy: Keep a count of phdrs
>       perf buildid-cache: kcore_copy: Calculate offset from phnum
>       perf buildid-cache: kcore_copy: Layout sections
>       perf buildid-cache: kcore_copy: Iterate phdrs
>       perf buildid-cache: kcore_copy: Get rid of kernel_map
>       perf buildid-cache: kcore_copy: Copy x86 PTI entry trampoline sections
>       perf buildid-cache: kcore_copy: Amend the offset of sections that remap kernel text