linux-kernel - Re: [PATCH v5 0/3] enable early printing of hashed pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516111348.1abf69a1@gandalf.local.home>
Date:   Wed, 16 May 2018 11:13:48 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Anna-Maria Gleixner <anna-maria@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/3] enable early printing of hashed pointers


I think the series looks good, although if Linus takes my last patch,
it may conflict badly with the third patch. I'll have to look into that.

Anyway, Andrew, you want to take this in your tree?

-- Steve


On Wed, 16 May 2018 09:17:36 +1000
"Tobin C. Harding" <me@...in.cc> wrote:

> Currently if an attempt is made to print a pointer before there is
> enough entropy then '(____ptrval____)' is printed.  This makes debugging
> stack traces during early boot difficult.
> 
> One partial solution to this problem is to use the hw RNG if it is
> available.
> 
> Patch 1 - Whitespace fixes.
> Patch 2 - Fix get_random_bytes_arch()
> Patch 3 - Use hw RNG for pointer hashing if available (by default).
> 
> 
> thanks,
> Tobin.
> 
> v4 -> v5
>  - Use 'upside-down-xmas-tree' style to declare local variables (Steve)
>  - Added Reviewed-by tag from Steve (patch 2 and 3).
> 
> v3 -> v4
>  - remove last patch of series (command line option patch)
> 
> v2 -> v3
>  - Add __ro_after_init (suggested by Kees).
> 
> v1 -> v2
>  - Use min_t() instead of min() (thanks checkpatch).
>  - Add __must_check to function declaration (thanks Steve).
>  - Use hw RNG by default if available (as originally suggested by Kees).
>  - Add command line option to use cryptographically insecure hashing.
>    If debug_early_boot is enabled use hash_long() instead of siphash
>    (as requested by Steve, and solves original problem for Anna-Maria).
>  - Added Acked-by tag from Ted (patch 1 and 2)
> 
> 
> 
> *** BLURB HERE ***
> 
> Tobin C. Harding (3):
>   random: Fix whitespace pre random-bytes work
>   random: Return nbytes filled from hw RNG
>   vsprintf: Use hw RNG for ptr_key
> 
>  drivers/char/random.c  | 19 ++++++++++---------
>  include/linux/random.h |  2 +-
>  lib/vsprintf.c         | 19 ++++++++++++++++---
>  3 files changed, 27 insertions(+), 13 deletions(-)
>