linux-kernel - Re: [PATCH v4 3/3] driver-core: print bus registration error value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180516153818.GC23725@kroah.com>
Date:   Wed, 16 May 2018 17:38:18 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Schmaus <flo@...kplace.eu>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] driver-core: print bus registration error value

On Wed, May 16, 2018 at 02:09:54PM +0200, Florian Schmaus wrote:
> On 16.05.2018 14:05, Florian Schmaus wrote:
> > Signed-off-by: Florian Schmaus <flo@...kplace.eu>
> > ---
> > 
> > Notes:
> >     - Use correct member name 'bus_register_error'
> >     - Only print out error code if it is non-zero
> > 
> >  drivers/base/bus.c    |  4 +++-
> >  drivers/base/driver.c | 13 ++++++++++---
> >  2 files changed, 13 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/base/bus.c b/drivers/base/bus.c
> > index dce677dddba4..5814ecb07648 100644
> > --- a/drivers/base/bus.c
> > +++ b/drivers/base/bus.c
> > @@ -849,8 +849,10 @@ int bus_register(struct bus_type *bus)
> >  	struct lock_class_key *key = &bus->lock_key;
> >  
> >  	priv = kzalloc(sizeof(struct subsys_private), GFP_KERNEL);
> > -	if (!priv)
> > +	if (!priv) {
> > +		bus->bus_register_error = -ENOMEM;
> >  		return -ENOMEM;
> > +	}
> >  
> >  	priv->bus = bus;
> >  	bus->p = priv;
> 
> I'm sorry, this change was meant to be part of 2/3 (and not 3/3). Shall
> I send a v5 where this is fixed?

Well, I can't take it as-is, so of course :)

thanks,

greg k-h