linux-kernel - Re: [PATCH -next] signal/mips: Report FPE_FLTUNK for undiagnosed floating point exceptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k1s3jd95.fsf@xmission.com>
Date:   Wed, 16 May 2018 20:13:10 -0500
From:   ebiederm@...ssion.com (Eric W. Biederman)
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     James Hogan <jhogan@...nel.org>, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH -next] signal/mips: Report FPE_FLTUNK for undiagnosed floating point exceptions

Guenter Roeck <linux@...ck-us.net> writes:

> Most mips builds fail with
>
> arch/mips/kernel/traps.c: In function ‘force_fcr31_sig’:
> arch/mips/kernel/traps.c:732:2: error:
> 	‘si_code’ may be used uninitialized in this function
>
> Fix the problem by initializing si_code with FPE_FLTUNK (undiagnosed
> floating point exception).
>
> Fixes: f43a54a0d916 ("signal/mips: Use force_sig_fault where appropriate")
> Cc: linux-mips@...ux-mips.org
> Cc: Eric W. Biederman <ebiederm@...ssion.com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>

Applied.  Thank you.

Eric

> ---
> Feel free to merge into the patch introducing the problem.
>
>  arch/mips/kernel/traps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 66ec4b0b484d..d67fa74622ee 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -716,7 +716,7 @@ asmlinkage void do_ov(struct pt_regs *regs)
>  void force_fcr31_sig(unsigned long fcr31, void __user *fault_addr,
>  		     struct task_struct *tsk)
>  {
> -	int si_code;
> +	int si_code = FPE_FLTUNK;
>  
>  	if (fcr31 & FPU_CSR_INV_X)
>  		si_code = FPE_FLTINV;