linux-kernel - Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3ce1af5-7b99-38db-fc51-4d580db1e87e@linux.intel.com>
Date:   Thu, 17 May 2018 10:48:14 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Chris Chiu <chiu@...lessm.com>
Cc:     Daniel Drake <drake@...lessm.com>,
        Jian-Hong Pan <jian-hong@...lessm.com>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jani Nikula <jani.nikula@...el.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Adrian Salido <salidoa@...gle.com>,
        Jason Gerecke <killertofu@...il.com>,
        linux-input <linux-input@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Linux Upstreaming Team <linux@...lessm.com>
Subject: Re: [BUG] i2c-hid: ELAN Touchpad does not work on ASUS X580GD

Hi

On 05/15/2018 01:20 PM, Jarkko Nikula wrote:
> On 05/15/2018 06:22 AM, Chris Chiu wrote:
>> What if I change the 120MHz to 180MHz and then make sure that the I2C 
>> operates
>> in target FS mode frequency 400kHz via scope? Would there be any side 
>> effect?
>> Maybe some other busses frequency could be also affected and causing 
>> some other
>> component malfunction?
>>
> Should be safe. It is only clock rate information when registering a 
> fixed clock with known rate in intel-lpss.c and i2c-designware uses that 
> info when calculating the timing parameters. I.e. it doesn't change any 
> internal clocks.
> 
> I'm trying to find a contact who can confirm what is the expected rate 
> of I2C input clock and is it common to all Cannon Lake HW.
> 
I got confirmation that input clock is actually even higher 216 Mhz.

While checking does it cover all of those CNL CNL-LP and CNL-H PCI IDs 
may I add your Jian-Hong, Chris and Daniel email addresses to Repored-by 
tags in a fix patch?

-- 
Jarkko