linux-kernel - Re: [PATCH 4.4 159/190] ipsec: check return value of skb_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180517091002.GH25318@kroah.com>
Date:   Thu, 17 May 2018 11:10:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Nathan Chancellor <natechancellor@...il.com>
Subject: Re: [PATCH 4.4 159/190] ipsec: check return value of skb_to_sgvec
 always

On Wed, May 16, 2018 at 02:58:02PM +0100, Ben Hutchings wrote:
> On Wed, 2018-04-11 at 20:36 +0200, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Jason A. Donenfeld <Jason@...c4.com>
> > 
> > commit 3f29770723fe498a5c5f57c3a31a996ebdde03e1 upstream.
> [...]
> 
> This leaves the error paths in esp{4,6}.c leaking memory; fixed
> upstream by:
> 
> commit e6194923237f3952b955c343b65b211f36bce01c
> Author: Steffen Klassert <steffen.klassert@...unet.com>
> Date:   Thu Jul 13 09:13:30 2017 +0200
> 
>     esp: Fix memleaks on error paths.

Really?  That patch doesn't apply at all.  It looks like this patch
fixes things that happened after the above patch.

Or am I confused?

thanks,

greg k-h