linux-kernel - Re: [PATCH] ima: Fix pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 May 2018 14:17:59 +0200
From:   Petr Vorel <pvorel@...e.cz>
To:     Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:     linux-integrity@...r.kernel.org,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] ima: Fix pr_fmt() redefinition

Hi Mimi,

> On Thu, 2018-05-17 at 12:47 +0200, Petr Vorel wrote:
> > Previous definition was too late and caused problems in powerpc allyesconfig:
> > security/integrity/ima/ima_kexec.c:18:0: warning: "pr_fmt" redefined
> >  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

> > In file included from include/linux/kernel.h:14:0,
> >                  from include/asm-generic/bug.h:18,
> >                  from arch/powerpc/include/asm/bug.h:128,
> >                  from include/linux/bug.h:5,
> >                  from include/linux/seq_file.h:7,
> >                  from security/integrity/ima/ima_kexec.c:13:
> > include/linux/printk.h:288:0: note: this is the location of the previous definition
> >  #define pr_fmt(fmt) fmt

> > Fixes: 3dea0d93d257 ("ima: Unify logging")

> > Signed-off-by: Petr Vorel <pvorel@...e.cz>
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>

> As the original patch hasn't been upstreamed yet, I'll squash this fix
> with the original patch.
Make sense, thanks!

> thanks!

> Mimi


Kind regards,
Petr