linux-kernel - Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0997fec-ba06-0d1d-a43d-fcc1600484f5@deltatee.com>
Date:   Thu, 17 May 2018 09:48:04 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     dmeyer@...aio.com, kurt.schwemmer@...rosemi.com,
        linux-pci@...r.kernel.org, linux-ntb@...glegroups.com
Cc:     bhelgaas@...gle.com, jdmason@...zu.us, dave.jiang@...el.com,
        allenbh@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality
 with IOMMU On

Thanks for your hard work on this Doug!

On 17/05/18 06:00 AM, dmeyer@...aio.com wrote:

> +	if (pci_enable_device(pdev)) {
> +		dev_err(&pdev->dev, "Cannot enable Switchtec device\n");
> +		return;
> +	}

I suspect we should probably cass pci_disable_device() before leaving
this function so it's in the same state we started. Just like we unmap
the mmio.

Logan