[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <385156660.62726.1526573192894@email.1und1.de>
Date: Thu, 17 May 2018 18:06:32 +0200 (CEST)
From: Stefan Wahren <stefan.wahren@...e.com>
To: Eric Anholt <eric@...olt.net>,
Vince Weaver <vincent.weaver@...ne.edu>
Cc: linux-rpi-kernel@...ts.infradead.org,
bcm-kernel-feedback-list@...adcom.com,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: bcm2835: Add the PMU to the devicetree.
> Vince Weaver <vincent.weaver@...ne.edu> hat am 17. Mai 2018 um 16:11 geschrieben:
>
>
> On Thu, 17 May 2018, Eric Anholt wrote:
>
> > diff --git a/arch/arm/boot/dts/bcm2837.dtsi b/arch/arm/boot/dts/bcm2837.dtsi
> > index 7704bb029605..1f5e5c782835 100644
> > --- a/arch/arm/boot/dts/bcm2837.dtsi
> > +++ b/arch/arm/boot/dts/bcm2837.dtsi
> > @@ -17,6 +17,12 @@
> > };
> > };
> >
> > + arm-pmu {
> > + compatible = "arm,cortex-a53-pmu", "arm,cortex-a7-pmu";
> > + interrupt-parent = <&local_intc>;
> > + interrupts = <9 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > +
>
> why this and not
>
> arm-pmu {
> compatible = "arm,armv8-pmuv3";
> interrupt-parent = <&local_intc>;
> interrupts = <9>;
> };
>
> which works, though when I didn't get very far when I submitted the patch
> to add this last August.
Eric's variant is more specific so we better chose this. The init code diverse between the general arm,armv8-pmuv3 and arm,cortex-a53-pmu.
>
> Vince
>
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
Powered by blists - more mailing lists