linux-kernel - Re: Fw: [PATCHSET] workqueue: Show the latest workqueue name in /proc/PID/{comm,stat,status}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+55aFwpwho_MMxuFHDKgffH4Fz93wf3A6QVNZmCyNZ8G3xyng@mail.gmail.com>
Date:   Thu, 17 May 2018 10:01:24 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Tejun Heo <tj@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Fw: [PATCHSET] workqueue: Show the latest workqueue name in /proc/PID/{comm,stat,status}

On Thu, May 17, 2018 at 12:51 AM Alexey Dobriyan <adobriyan@...il.com>
wrote:

> I'd say anything that extends ->comm past 16 charactes is no-no.
> The reason is that userspace may do something stupid like:

>          char comm[16];

Not may - does. We're already talking to the procps-ng people exactly
because of this.

That said, nobody actually mis-parses anything or overflows any buffers
(you'd actually have to work at it to do so), it's just that they don't
save the full length of the result.

So we can extend the kernel size (there are others who want it
independently of the workqueue issue), but some of the tools simply won't
show the full name until updated.

So instead of showing "[kworker/4:2-events]", current procps-ng shows
"[kworker/4:2-eve]" for example. Annoying, but not really any more cryptic
than the current situation without the patch.

               Linus