lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b4a96b0e326cd45928f97d6e5796c748@codeaurora.org>
Date:   Thu, 17 May 2018 11:35:44 -0700
From:   Jeff Johnson <jjohnson@...eaurora.org>
To:     Ramon Fried <ramon.fried@...aro.org>
Cc:     kvalo@...eaurora.org, linux-kernel@...r.kernel.org,
        wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, Eyal Ilsar <eilsar@...eaurora.org>,
        linux-wireless-owner@...r.kernel.org
Subject: Re: [PATCH] wcn36xx: Add support for Factory Test Mode (FTM)

On 2018-05-17 04:32, Ramon Fried wrote:
> From: Eyal Ilsar <eilsar@...eaurora.org>
...
> +static int wcn36xx_smd_process_ptt_msg_rsp(void *buf, size_t len,
> +					   void **p_ptt_rsp_msg)
> +{
> +	struct wcn36xx_hal_process_ptt_msg_rsp_msg *rsp;
> +	int ret = 0;

why initialize 'ret' when you immediately overwrite?

> +	ret = wcn36xx_smd_rsp_status_check(buf, len);
...
> +	if (rsp->header.len > 0) {
> +		*p_ptt_rsp_msg = kmalloc(rsp->header.len, GFP_ATOMIC);

NULL check required?

> +		memcpy(*p_ptt_rsp_msg, rsp->ptt_msg, rsp->header.len);
> +	}
> +	return ret;
> +}
> +
> +int wcn36xx_smd_process_ptt_msg(struct wcn36xx *wcn,
> +				struct ieee80211_vif *vif, void *ptt_msg, size_t len,
> +		void **ptt_rsp_msg)
> +{
> +	struct wcn36xx_hal_process_ptt_msg_req_msg *p_msg_body;
> +	int ret = 0;

why initialize 'ret' when it is always overwritten before use?

> +	ret = wcn36xx_smd_send_and_wait(wcn, p_msg_body->header.len);

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ