linux-kernel - Re: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201805180343.gKays0s7%fengguang.wu@intel.com>
Date:   Fri, 18 May 2018 03:59:36 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Neil Armstrong <narmstrong@...libre.com>
Cc:     kbuild-all@...org, airlied@...ux.ie, hans.verkuil@...co.com,
        lee.jones@...aro.org, olof@...om.net, seanpaul@...gle.com,
        Neil Armstrong <narmstrong@...libre.com>,
        sadolfsson@...gle.com, intel-gfx@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        fparent@...libre.com, felixe@...gle.com, bleung@...gle.com,
        darekm@...gle.com, linux-media@...r.kernel.org
Subject: Re: [Intel-gfx] [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC
 driver

Hi Neil,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Neil-Armstrong/Add-ChromeOS-EC-CEC-Support/20180516-180519
base:   git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   drivers/media//platform/cros-ec-cec/cros-ec-cec.c: In function 'cros_ec_cec_get_notifier':
>> drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: error: 'pci_bus_type' undeclared (first use in this function); did you mean 'pci_pcie_type'?
       d = bus_find_device_by_name(&pci_bus_type, NULL,
                                    ^~~~~~~~~~~~
                                    pci_pcie_type
   drivers/media//platform/cros-ec-cec/cros-ec-cec.c:231:33: note: each undeclared identifier is reported only once for each function it appears in

vim +231 drivers/media//platform/cros-ec-cec/cros-ec-cec.c

   217	
   218	static int cros_ec_cec_get_notifier(struct device *dev,
   219					    struct cec_notifier **notify)
   220	{
   221		int i;
   222	
   223		for (i = 0 ; i < ARRAY_SIZE(cec_dmi_match_table) ; ++i) {
   224			const struct cec_dmi_match *m = &cec_dmi_match_table[i];
   225	
   226			if (dmi_match(DMI_SYS_VENDOR, m->sys_vendor) &&
   227			    dmi_match(DMI_PRODUCT_NAME, m->product_name)) {
   228				struct device *d;
   229	
   230				/* Find the device, bail out if not yet registered */
 > 231				d = bus_find_device_by_name(&pci_bus_type, NULL,
   232							    m->devname);
   233				if (!d)
   234					return -EPROBE_DEFER;
   235	
   236				*notify = cec_notifier_get_conn(d, m->conn);
   237				return 0;
   238			}
   239		}
   240	
   241		/* Hardware support must be added in the cec_dmi_match_table */
   242		dev_warn(dev, "CEC notifier not configured for this hardware\n");
   243	
   244		return -ENODEV;
   245	}
   246	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (45533 bytes)