| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 May 2018 17:15:53 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Jiri Olsa <jolsa@...nel.org>, Kim Phillips <kim.phillips@....com>
Cc: Ingo Molnar <mingo@...nel.org>,
Clark Williams <williams@...hat.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Andi Kleen <ak@...ux.intel.com>,
David Ahern <dsahern@...il.com>,
Kan Liang <kan.liang@...ux.intel.com>,
Namhyung Kim <namhyung@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
Wang Nan <wangnan0@...wei.com>
Subject: Re: [PATCH 01/11] perf tests parse-events: Add intel_pt parse test
Em Wed, May 16, 2018 at 04:33:55PM -0500, Kim Phillips escreveu:
> On Wed, 16 May 2018 11:48:58 -0300
> Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
>
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> >
> > To avoid regressions such as the one fixed by 4a35a9027f64 ("Revert
> > "perf pmu: Fix pmu events parsing rule""), where '-e intel_pt//u' got
> > broken, with this new entry in this 'perf tests' subtest, we would have
> > caught it before pushing upstream.
> >
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> > Cc: Adrian Hunter <adrian.hunter@...el.com>
> > Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> > Cc: Andi Kleen <ak@...ux.intel.com>
> > Cc: David Ahern <dsahern@...il.com>
> > Cc: Jiri Olsa <jolsa@...nel.org>
> > Cc: Kan Liang <kan.liang@...ux.intel.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Peter Zijlstra <peterz@...radead.org>
> > Cc: Wang Nan <wangnan0@...wei.com>
> > Link: https://lkml.kernel.org/n/tip-kw62fys9bwdgsp722so2ln1l@git.kernel.org
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> > ---
>
> This causes a SEGV on Arm, and an Intel box without Intel-PT h/w:
>
> (gdb) run test -F -v 6
> Starting program: /home/kimphi01/git/linux-perf-acme/tools/perf/perf test -F -v 6
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
> 6: Parse event definition strings :
> --- start ---
> running test 0 'syscalls:sys_enter_openat'
> Using CPUID GenuineIntel-6-3C
> <SNIP>
> running test 51 'L1-dcache-misses/name=cachepmu/'
> running test 52 'intel_pt//u'
>
> Program received signal SIGSEGV, Segmentation fault.
> __GI___vasprintf_chk (result_ptr=0x8, flags=1, format=<optimized out>, args=args@...ry=0x7fffffffbf30)
> at vasprintf_chk.c:88
> 88 vasprintf_chk.c: No such file or directory.
> (gdb) bt
> #0 __GI___vasprintf_chk (result_ptr=0x8, flags=1, format=<optimized out>, args=args@...ry=0x7fffffffbf30)
> at vasprintf_chk.c:88
> #1 0x00007ffff6456e6f in __asprintf_chk (result_ptr=result_ptr@...ry=0x8, flags=flags@...ry=1,
> format=format@...ry=0x555555992e80 "Cannot find PMU `%s'. Missing kernel support?") at asprintf_chk.c:32
> #2 0x0000555555766836 in asprintf (__fmt=0x555555992e80 "Cannot find PMU `%s'. Missing kernel support?", __ptr=0x8)
> at /usr/include/x86_64-linux-gnu/bits/stdio2.h:178
> #3 parse_events_add_pmu (parse_state=parse_state@...ry=0x7fffffffdda0, list=list@...ry=0x555555e137d0,
> name=0x5555563e84e0 "intel_pt", head_config=0x0, auto_merge_stats=auto_merge_stats@...ry=false,
> use_alias=use_alias@...ry=false) at util/parse-events.c:1236
Humm:
struct parse_events_error *err = parse_state->error;
pmu = perf_pmu__find(name);
if (!pmu) {
if (asprintf(&err->str,
"Cannot find PMU `%s'. Missing kernel support?",
name) < 0)
$ pahole -C parse_events_error ~/bin/perf
struct parse_events_error {
int idx; /* 0 4 */
/* XXX 4 bytes hole, try to pack */
char * str; /* 8 8 */
char * help; /* 16 8 */
/* size: 24, cachelines: 1, members: 3 */
/* sum members: 20, holes: 1, sum holes: 4 */
/* last cacheline: 24 bytes */
};
$
So parse_state->error == NULL, Jiri, ideas?
- Arnaldo
> #4 0x00005555557aaaae in parse_events_parse (_parse_state=_parse_state@...ry=0x7fffffffdda0, scanner=0x555555d38c40)
> at util/parse-events.y:235
> #5 0x0000555555761ccf in parse_events__scanner (start_token=258, parse_state=0x7fffffffdda0, str=<optimized out>)
> at util/parse-events.c:1796
> #6 parse_events (evlist=evlist@...ry=0x555555d381f0, str=<optimized out>, err=err@...ry=0x0)
> at util/parse-events.c:1836
> #7 0x000055555571eb65 in test_event (e=0x555555bf4f80 <test.events+1248>, e=0x555555bf4f80 <test.events+1248>)
> at tests/parse-events.c:1695
> #8 test_events (events=0x555555bf4aa0 <test.events>, cnt=53) at tests/parse-events.c:1717
> #9 test__parse_events (test=<optimized out>, subtest=<optimized out>) at tests/parse-events.c:1837
> #10 0x0000555555716a11 in run_test (subtest=-1, test=0x555555bfca78 <generic_tests+280>) at tests/builtin-test.c:348
> #11 test_and_print (t=t@...ry=0x555555bfca78 <generic_tests+280>, force_skip=force_skip@...ry=false,
> subtest=subtest@...ry=-1) at tests/builtin-test.c:378
> #12 0x0000555555717e2f in __cmd_test (skiplist=0x0, argv=0x7fffffffe5c0, argc=1) at tests/builtin-test.c:570
> #13 cmd_test (argc=1, argv=0x7fffffffe5c0) at tests/builtin-test.c:709
> #14 0x0000555555738b41 in run_builtin (p=0x555555bfd848 <commands+552>, argc=4, argv=0x7fffffffe5c0) at perf.c:303
> #15 0x0000555555738e3e in handle_internal_command (argc=4, argv=0x7fffffffe5c0) at perf.c:355
> #16 0x00005555556b3901 in run_argv (argcp=<synthetic pointer>, argv=<synthetic pointer>) at perf.c:399
> #17 main (argc=<optimized out>, argv=0x7fffffffe5c0) at perf.c:543
> (gdb)
>
> Thanks,
>
> Kim
Powered by blists - more mailing lists