linux-kernel - Re: [PATCH 2/2] kselftests: ftrace: Add tests for the preemptoff and irqsoff tracers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180518170001.GA87521@joelaf.mtv.corp.google.com>
Date:   Fri, 18 May 2018 10:00:01 -0700
From:   Joel Fernandes <joel@...lfernandes.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
        Peter Zilstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Glexiner <tglx@...utronix.de>,
        Boqun Feng <boqun.feng@...il.com>,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>,
        Todd Kjos <tkjos@...gle.com>,
        Erick Reyes <erickreyes@...gle.com>,
        Julia Cartwright <julia@...com>, kernel-team@...roid.com
Subject: Re: [PATCH 2/2] kselftests: ftrace: Add tests for the preemptoff and
 irqsoff tracers

On Sat, May 19, 2018 at 12:32:41AM +0900, Masami Hiramatsu wrote:
> Hi Joel,
> 
> 55ty jmnOn Thu, 17 May 2018 18:54:21 -0700
> "Joel Fernandes (Google)" <joel@...lfernandes.org> wrote:
> 
> > Here we add unit tests for the preemptoff and irqsoff tracer by using a
> > kernel module introduced previously to trigger atomic sections in the
> > kernel.
> > 
> > Cc: Steven Rostedt <rostedt@...dmis.org>
> > Cc: Peter Zilstra <peterz@...radead.org>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> > Cc: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > Cc: Namhyung Kim <namhyung@...nel.org>
> > Cc: Thomas Glexiner <tglx@...utronix.de>
> > Cc: Boqun Feng <boqun.feng@...il.com>
> > Cc: Paul McKenney <paulmck@...ux.vnet.ibm.com>
> > Cc: Masami Hiramatsu <mhiramat@...nel.org>
> > Cc: Todd Kjos <tkjos@...gle.com>
> > Cc: Erick Reyes <erickreyes@...gle.com>
> > Cc: Julia Cartwright <julia@...com>
> > Cc: kernel-team@...roid.com
> > Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
> > ---
> >  tools/testing/selftests/ftrace/config         |  3 +
> >  .../test.d/preemptirq/irqsoff_tracer.tc       | 74 +++++++++++++++++++
> >  2 files changed, 77 insertions(+)
> >  create mode 100644 tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > 
> > diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
> > index b01924c71c09..29588b328345 100644
> > --- a/tools/testing/selftests/ftrace/config
> > +++ b/tools/testing/selftests/ftrace/config
> > @@ -4,3 +4,6 @@ CONFIG_FUNCTION_PROFILER=y
> >  CONFIG_TRACER_SNAPSHOT=y
> >  CONFIG_STACK_TRACER=y
> >  CONFIG_HIST_TRIGGERS=y
> > +CONFIG_PREEMPT_TRACER=y
> > +CONFIG_IRQSOFF_TRACER=y
> > +CONFIG_TEST_ATOMIC_SECTIONS=m
> > diff --git a/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > new file mode 100644
> > index 000000000000..b76d781c5645
> > --- /dev/null
> > +++ b/tools/testing/selftests/ftrace/test.d/preemptirq/irqsoff_tracer.tc
> > @@ -0,0 +1,74 @@
> > +#!/bin/sh
> > +# SPDX-License-Identifier: GPL-2.0
> > +# description: test for the preemptirqsoff tracer
> > +
> > +MOD=test_atomic_sections
> > +
> > +fail() {
> > +    reset_tracer
> > +    rmmod $MOD || true
> > +    exit_fail
> > +}
> > +
> > +unsup() { #msg
> > +    reset_tracer
> > +    rmmod $MOD || true
> > +    echo $1
> > +    exit_unsupported
> > +}
> > +
> > +modprobe $MOD || unsup "$MOD module not available"
> > +rmmod $MOD
> > +
> > +grep "preemptoff" available_tracers || unsup "preemptoff tracer not enabled"
> > +grep "irqsoff" available_tracers || unsup "irqsoff tracer not enabled"
> 
> Could you pass "-q" for all grep command in this script if it just for checking the pattern exists?

Fixed, thanks!

Will send out update rolled into the series its testing.

- Joel