linux-kernel - Re: [PATCH] x86/mm: Drop TS_COMPAT on 64-bit exec() syscall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 May 2018 15:03:15 -0700
From:   Andy Lutomirski <luto@...nel.org>
To:     Dmitry Safonov <dima@...sta.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, izbyshev@...ras.ru,
        Alexander Monakov <amonakov@...ras.ru>,
        Andrew Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...e.de>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Dmitry Safonov <0x7f454c46@...il.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux-MM <linux-mm@...ck.org>, X86 ML <x86@...nel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] x86/mm: Drop TS_COMPAT on 64-bit exec() syscall

On Thu, May 17, 2018 at 4:40 PM Dmitry Safonov <dima@...sta.com> wrote:
> Some selftests are failing, but the same way as before the patch
> (ITOW, it's not regression):
> [root@...alhost self]# grep FAIL out
> [FAIL]  Reg 1 mismatch: requested 0x0; got 0x3
> [FAIL]  Reg 15 mismatch: requested 0x8badf00d5aadc0de; got
> 0xffffff425aadc0de
> [FAIL]  Reg 15 mismatch: requested 0x8badf00d5aadc0de; got
> 0xffffff425aadc0de
> [FAIL]  Reg 15 mismatch: requested 0x8badf00d5aadc0de; got
> 0xffffff425aadc0de

Are you on AMD?  Can you try this patch:

https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/commit/?h=x86/fixes&id=c88aa6d53840e48970c54f9ef70c79415033b32d

and give me a Tested-by if it fixes it for you?

> [FAIL]  f[u]comi[p] errors: 1
> [FAIL]  fisttp errors: 1'

I don't know about these.

> [FAIL]  R8 has changed:0000000000000000
> [FAIL]  R9 has changed:0000000000000000
> [FAIL]  R10 has changed:0000000000000000
> [FAIL]  R11 has changed:0000000000000000
> [FAIL]  R8 has changed:0000000000000000
> [FAIL]  R9 has changed:0000000000000000
> [FAIL]  R10 has changed:0000000000000000
> [FAIL]  R11 has changed:0000000000000000

The patch that added these test lines was the same patch that should have
made them pass.  Are you sure your tests match your running kernel?  You
need commit 8bb2610bc4967f19672444a7b0407367f1540028.

If you still have failures, can you send me the complete output from the
test_syscall_vdso test?

--Andy