linux-kernel - Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for $ALLSOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180518055940.poyba3abl2mlzm5l@gmail.com>
Date:   Thu, 17 May 2018 19:59:40 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Joey Pabalinas <joeypabalinas@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>
Subject: Re: [PATCH] scripts/tags.sh: don't rely on parsing `ls` for
 $ALLSOURCE_ARCHS generation

On Fri, May 18, 2018 at 02:46:32PM +0900, Masahiro Yamada wrote:
> Andrew picked it up, but this patch is *bad*
> 
> You missed arch/Kconfig.
> 
> $(cd "${tree}arch/" && echo *)
> contains Kconfig, but it is not arch.

That was also something that I found a bit weird myself, but I had
assumed there was a good reason for keeping that. The original
command also returns a string containing Kconfig:

>  tree="$PWD/"
>  echo "$tree"
>  ALLSOURCE_ARCHS=""
>  for arch in `ls ${tree}arch`; do
>          ALLSOURCE_ARCHS="${ALLSOURCE_ARCHS} "${arch##\/}
>  done
>  echo "$ALLSOURCE_ARCHS"'

gives the same output as my command (albeit with an extra leading
space that shouldn't be important):

>  /store/code/projects/kernel/linux/
>   Kconfig alpha arc arm arm64 c6x h8300 hexagon ia64 m68k microblaze mips nds32 nios2 openrisc parisc powerpc riscv s390 sh sparc um unicore32 x86 xtensa

However, if there really is no reason for that being there, I
have no complaints against fixing it. I'll send a v3 in a bit.

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)