linux-kernel - Re: [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180518224125.w2ty35wngxbzx6kv@treble>
Date:   Fri, 18 May 2018 17:41:25 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Jiri Slaby <jslaby@...e.cz>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andy Lutomirski <luto@...nel.org>,
        Borislav Petkov <bp@...en8.de>, mingo@...hat.com,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH v3 1/6] x86/stacktrace: do not unwind after user regs

On Fri, May 18, 2018 at 08:55:47AM +0200, Ingo Molnar wrote:
> 
> * Jiri Slaby <jslaby@...e.cz> wrote:
> 
> > Josh pointed out, that there is no way a frame can be after user regs.
> > So remove the last unwind and the check.
> > 
> > Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: "H. Peter Anvin" <hpa@...or.com>
> > Cc: x86@...nel.org
> > Cc: Josh Poimboeuf <jpoimboe@...hat.com>
> 
> Josh: an Acked-by or Reviewed-by for the whole series from you would be nice.

The patches look good, but I want to run it through some testing before
I give them an ACK.

-- 
Josh