linux-kernel - Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 May 2018 10:38:27 +0300
From:   Roger Quadros <rogerq@...com>
To:     Andrzej Hajda <a.hajda@...sung.com>,
        kbuild test robot <fengguang.wu@...el.com>
CC:     <kbuild-all@...org>, Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static

On 18/05/18 08:39, Andrzej Hajda wrote:
> On 17.05.2018 18:06, kbuild test robot wrote:
>> Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
>> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> 
> It should be static of course, my bad.
> 
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>

I don't think we accept patches from robots, yet :)

> 
>  --
> Regards
> Andrzej
> 
>> ---
>>  drd.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
>> index 2706824..218371f 100644
>> --- a/drivers/usb/dwc3/drd.c
>> +++ b/drivers/usb/dwc3/drd.c
>> @@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
>>  	return NOTIFY_DONE;
>>  }
>>  
>> -struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>> +static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
>>  {
>>  	struct device *dev = dwc->dev;
>>  	struct device_node *np_phy, *np_conn;
>>
>>
>>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki