[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAAFQd5C+S0admv8qVc-e+xBGwxku8+jF7WXKmt2qzD1NEtq8yA@mail.gmail.com>
Date: Fri, 18 May 2018 17:57:06 +0900
From: Tomasz Figa <tfiga@...omium.org>
To: Stanimir Varbanov <stanimir.varbanov@...aro.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Hans Verkuil <hverkuil@...all.nl>,
Linux Media Mailing List <linux-media@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
vgarodia@...eaurora.org
Subject: Re: [PATCH v2 01/29] venus: hfi_msgs: correct pointer increment
On Tue, May 15, 2018 at 5:13 PM Stanimir Varbanov <
stanimir.varbanov@...aro.org> wrote:
> Data pointer should be incremented by size of the structure not
> the size of a pointer, correct the mistake.
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@...aro.org>
> ---
> drivers/media/platform/qcom/venus/hfi_msgs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/media/platform/qcom/venus/hfi_msgs.c
b/drivers/media/platform/qcom/venus/hfi_msgs.c
> index 90c93d9603dc..589e1a6b36a9 100644
> --- a/drivers/media/platform/qcom/venus/hfi_msgs.c
> +++ b/drivers/media/platform/qcom/venus/hfi_msgs.c
> @@ -60,14 +60,14 @@ static void event_seq_changed(struct venus_core
*core, struct venus_inst *inst,
> frame_sz = (struct hfi_framesize *)data_ptr;
> event.width = frame_sz->width;
> event.height = frame_sz->height;
> - data_ptr += sizeof(frame_sz);
> + data_ptr += sizeof(*frame_sz);
> break;
> case HFI_PROPERTY_PARAM_PROFILE_LEVEL_CURRENT:
> data_ptr += sizeof(u32);
> profile_level = (struct hfi_profile_level
*)data_ptr;
> event.profile = profile_level->profile;
> event.level = profile_level->level;
> - data_ptr += sizeof(profile_level);
> + data_ptr += sizeof(*profile_level);
> break;
> default:
> break;
> --
> 2.14.1
(Posted to v1 originally, since I missed v2.)
Reviewed-by: Tomasz Figa <tfiga@...omium.org>
Best regards,
Tomasz
Powered by blists - more mailing lists