linux-kernel - Re: [PATCH -resend 02/27] x86: assembly, use SYM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cd6a8bd-80a4-c1ad-bba9-bad63f6e053f@suse.cz>
Date:   Fri, 18 May 2018 11:17:16 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     mingo@...hat.com, linux-arch@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH -resend 02/27] x86: assembly, use SYM_DATA for data

On 05/15/2018, 08:39 AM, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...nel.org> wrote:
> 
>>
>> * Jiri Slaby <jslaby@...e.cz> wrote:
>>
>>> We make proper use of SYM_DATA on global data instead of marking them as
>>> ENTRY. ENTRY is intended for functions and shall be paired with ENDPROC.
>>> ENTRY also aligns symbols which creates unnecessary holes here between
>>> data.
>>>
>>> ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64 is
>>> simply dropped, as these symbols are local only.
>>
>> Yeah, so this commit talks about ENTRY() and ENDPROC(), while the new methods are 
>> SYM_FUNC_START()/END().
> 
> BTW., I like the series otherwise: for example in my comment above I wrote up the 
> SYM_FUNC_START()/END() names from memory, without having to look up the 
> primitives.

Thanks, I am about to send v6 in a short while. It addresses the comments.

-- 
js
suse labs