linux-kernel - Re: [PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jz-qzA-k0+6PvyALbwzpnRyB5SQpbDr9g-THiz7ZwH3g@mail.gmail.com>
Date:   Fri, 18 May 2018 12:03:20 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Ingo Molnar <mingo@...hat.com>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <len.brown@...el.com>, Pavel Machek <pavel@....cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v6 02/28] x86/asm/suspend: drop ENTRY from local data

On Fri, May 18, 2018 at 11:16 AM, Jiri Slaby <jslaby@...e.cz> wrote:
> ENTRY was intended for functions and shall be paired with ENDPROC.
> ENTRY also aligns symbols which creates unnecessary holes here between
> data.
>
> So drop ENTRY from saved_eip in wakeup_32 and many saved_* in wakeup_64,
> as these symbols are local only.
>
> We could use SYM_DATA_LOCAL for these symbols, but it was discouraged
> earlier [1].
>
> [1] https://lkml.org/lkml/2017/4/27/244
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: x86@...nel.org
> Cc: linux-pm@...r.kernel.org

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

> ---
>  arch/x86/kernel/acpi/wakeup_32.S |  2 +-
>  arch/x86/kernel/acpi/wakeup_64.S | 12 ++++++------
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/wakeup_32.S b/arch/x86/kernel/acpi/wakeup_32.S
> index 0c26b1b44e51..4203d4f0c68d 100644
> --- a/arch/x86/kernel/acpi/wakeup_32.S
> +++ b/arch/x86/kernel/acpi/wakeup_32.S
> @@ -90,7 +90,7 @@ ret_point:
>  .data
>  ALIGN
>  ENTRY(saved_magic)     .long   0
> -ENTRY(saved_eip)       .long   0
> +saved_eip:             .long 0
>
>  # saved registers
>  saved_idt:     .long   0,0
> diff --git a/arch/x86/kernel/acpi/wakeup_64.S b/arch/x86/kernel/acpi/wakeup_64.S
> index 50b8ed0317a3..510fa12aab73 100644
> --- a/arch/x86/kernel/acpi/wakeup_64.S
> +++ b/arch/x86/kernel/acpi/wakeup_64.S
> @@ -125,12 +125,12 @@ ENTRY(do_suspend_lowlevel)
>  ENDPROC(do_suspend_lowlevel)
>
>  .data
> -ENTRY(saved_rbp)       .quad   0
> -ENTRY(saved_rsi)       .quad   0
> -ENTRY(saved_rdi)       .quad   0
> -ENTRY(saved_rbx)       .quad   0
> +saved_rbp:             .quad   0
> +saved_rsi:             .quad   0
> +saved_rdi:             .quad   0
> +saved_rbx:             .quad   0
>
> -ENTRY(saved_rip)       .quad   0
> -ENTRY(saved_rsp)       .quad   0
> +saved_rip:             .quad   0
> +saved_rsp:             .quad   0
>
>  ENTRY(saved_magic)     .quad   0
> --
> 2.16.3
>