linux-kernel - Re: [PATCH V3 13/39] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1805191720130.1599@nanos.tec.linutronix.de>
Date:   Sat, 19 May 2018 17:21:24 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Reinette Chatre <reinette.chatre@...el.com>
cc:     fenghua.yu@...el.com, tony.luck@...el.com,
        vikas.shivappa@...ux.intel.com, gavin.hindman@...el.com,
        jithu.joseph@...el.com, dave.hansen@...el.com, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 13/39] x86/intel_rdt: Introduce "bit_usage" to display
 cache allocations details

On Wed, 25 Apr 2018, Reinette Chatre wrote:
> +		for (i = 0; i < r->num_closid; i++, ctrl++) {
> +			if (closid_allocated(i)) {

You can spare an indentation level if you just do:

			if (!closid_allocated())
	      			continue;

> +				mode = rdtgroup_mode_by_closid(i);
> +				switch (mode) {
> +				case RDT_MODE_SHAREABLE:
> +					sw_shareable |= *ctrl;
> +					break;
> +				case RDT_MODE_EXCLUSIVE:
> +					exclusive |= *ctrl;
> +					break;
> +				case RDT_NUM_MODES:
> +					WARN(1,
> +					     "invalid mode for closid %d\n", i);
> +					break;
> +				}

Thanks,

	tglx