[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20180520112658.1c84968b@archlinux>
Date: Sun, 20 May 2018 11:26:58 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Fabrice Gasnier <fabrice.gasnier@...com>
Cc: <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <mcoquelin.stm32@...il.com>,
<alexandre.torgue@...com>, <linux-iio@...r.kernel.org>,
<lars@...afoo.de>, <knaack.h@....de>, <pmeerw@...erw.net>,
<benjamin.gaignard@...aro.org>, <arnaud.pouliquen@...com>
Subject: Re: [PATCH] iio: adc: stm32-dfsdm: include stm32-dfsdm-adc.h
On Tue, 15 May 2018 17:19:17 +0200
Fabrice Gasnier <fabrice.gasnier@...com> wrote:
> Fix the following sparse warnings:
> CHECK drivers/iio/adc/stm32-dfsdm-adc.c
> symbol 'stm32_dfsdm_get_buff_cb' was not declared. Should it be static?
> symbol 'stm32_dfsdm_release_buff_cb' was not declared. Should it be static?
>
> BTW, move interrupt.h to sort headers alphabetically.
>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-dfsdm-adc.c | 4 ++--
> include/linux/iio/adc/stm32-dfsdm-adc.h | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c
> index 1b78bec..31462ae 100644
> --- a/drivers/iio/adc/stm32-dfsdm-adc.c
> +++ b/drivers/iio/adc/stm32-dfsdm-adc.c
> @@ -8,11 +8,11 @@
>
> #include <linux/dmaengine.h>
> #include <linux/dma-mapping.h>
> -#include <linux/interrupt.h>
> +#include <linux/iio/adc/stm32-dfsdm-adc.h>
> #include <linux/iio/buffer.h>
> #include <linux/iio/hw-consumer.h>
> -#include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> +#include <linux/interrupt.h>
> #include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/platform_device.h>
> diff --git a/include/linux/iio/adc/stm32-dfsdm-adc.h b/include/linux/iio/adc/stm32-dfsdm-adc.h
> index e7dc7a5..0da298b 100644
> --- a/include/linux/iio/adc/stm32-dfsdm-adc.h
> +++ b/include/linux/iio/adc/stm32-dfsdm-adc.h
> @@ -9,6 +9,8 @@
> #ifndef STM32_DFSDM_ADC_H
> #define STM32_DFSDM_ADC_H
>
> +#include <linux/iio/iio.h>
> +
> int stm32_dfsdm_get_buff_cb(struct iio_dev *iio_dev,
> int (*cb)(const void *data, size_t size,
> void *private),
Powered by blists - more mailing lists