[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJ3xEMhNC91YFcy-Qi+vk--DwSZ5wZdYMNp=-7mHUk9oag9HSg@mail.gmail.com>
Date: Mon, 21 May 2018 00:13:06 +0300
From: Or Gerlitz <gerlitz.or@...il.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc: Vlad Buslov <vladbu@...lanox.com>,
Linux Netdev List <netdev@...r.kernel.org>,
David Miller <davem@...emloft.net>,
Jamal Hadi Salim <jhs@...atatu.com>,
Cong Wang <xiyou.wangcong@...il.com>,
Jiri Pirko <jiri@...nulli.us>,
Pablo Neira Ayuso <pablo@...filter.org>,
kadlec@...ckhole.kfki.hu, Florian Westphal <fw@...len.de>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Eric Dumazet <edumazet@...gle.com>, keescook@...omium.org,
Linux Kernel <linux-kernel@...r.kernel.org>,
netfilter-devel@...r.kernel.org, coreteam@...filter.org,
Yevgeny Kliteynik <kliteyn@...lanox.com>
Subject: Re: [PATCH 13/14] net: sched: use unique idr insert function in
unlocked actions
On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
> On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
>> Substitute calls to action insert function with calls to action insert
>> unique function that warns if insertion overwrites index in idr.
>
> I know this patch may be gone on V2, but a general comment, please use
> the function names themselves instead of a textualized version. I.e.,
> s/action insert unique/tcf_idr_insert_unique/
disagree. While doing reviews I found out that if I ask the developer
to use higher
level / descriptive language and specifically to avoid putting
variable / function names in
patch titles and change logs, the quality gets ++ big time, vs if the
developer is allowed to say
net/mlx5: Changed add_vovo_bobo()
Added variable do_it_right to add_vovo_bobo(), now we are terribly good.
Powered by blists - more mailing lists