[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180520062631.GS26863@dragon>
Date: Sun, 20 May 2018 14:26:33 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: Andrey Smirnov <andrew.smirnov@...il.com>
Cc: Stefan Agner <stefan@...er.ch>,
Lucas Stach <l.stach@...gutronix.de>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] soc: imx: gpcv2: Do not pass static memory as
platform data
On Sat, May 19, 2018 at 03:35:55PM -0700, Andrey Smirnov wrote:
> On Tue, Apr 10, 2018 at 11:32 AM, Andrey Smirnov
> <andrew.smirnov@...il.com> wrote:
> > Platform device core assumes the ownership of dev.platform_data as
> > well as that it is dynamically allocated and it will try to kfree it
> > as a part of platform_device_release(). Change the code to use
> > platform_device_add_data() n instead of a pointer to a static memory
> > to avoid causing a BUG() when calling platform_device_put().
> >
> > The problem can be reproduced by artificially enabling the error path
> > of platform_device_add() call (around line 357).
> >
> > Note that this change also allows us to constify imx7_pgc_domains,
> > since we no longer need to be able to modify it.
> >
>
> Shawn,
>
> What's the status of these two patches? Do I need to change anything
> or are they good to go?
The patches were queued on imx/drivers branch for a while. I forgot to
let you know. Sorry.
Shawn
Powered by blists - more mailing lists