linux-kernel - Re: [PATCH net-next] net: dsa: b53: Extend platform data to include DSA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180520014250.GB14906@lunn.ch>
Date:   Sun, 20 May 2018 03:42:50 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: b53: Extend platform data to include
 DSA ports

On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
> Provide a means for !OF platforms to supply their DSA platform data
> configuration using the dsa_platform_data structure.

Hi Florian

It seems a bit odd adding the header file, but no code. Yes, this will
help simplify the merge dependencies for the ZII boards next cycle,
but can we have the actual code as well?

    Thanks
	Andrew
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  include/linux/platform_data/b53.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/platform_data/b53.h b/include/linux/platform_data/b53.h
> index 69d279c0da96..8eaef2f2b691 100644
> --- a/include/linux/platform_data/b53.h
> +++ b/include/linux/platform_data/b53.h
> @@ -20,8 +20,12 @@
>  #define __B53_H
>  
>  #include <linux/kernel.h>
> +#include <net/dsa.h>
>  
>  struct b53_platform_data {
> +	/* Must be first such that dsa_register_switch() can access it */
> +	struct dsa_chip_data cd;
> +
>  	u32 chip_id;
>  	u16 enabled_ports;
>  
> -- 
> 2.14.1
>