linux-kernel - Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 May 2018 13:58:20 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        "Luis R . Rodriguez" <mcgrof@...e.com>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for
 building nconf

2018-05-21 13:51 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
> On 05/20/2018 09:48 PM, Masahiro Yamada wrote:
>> 2018-05-21 8:41 GMT+09:00 Randy Dunlap <rdunlap@...radead.org>:
>>> On 05/20/2018 01:16 AM, Masahiro Yamada wrote:
>>>> Building nconf requires ncurses, but its presence is not checked.
>>>> Check and configure necessary packages by a shell script like the
>>>> other GUI frontends.
>>>>
>>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>>>> ---
>>>>
>>>
>>>> diff --git a/scripts/kconfig/nconf-cfg.sh b/scripts/kconfig/nconf-cfg.sh
>>>> new file mode 100644
>>>> index 0000000..8eb7948
>>>> --- /dev/null
>>>> +++ b/scripts/kconfig/nconf-cfg.sh
>>>> @@ -0,0 +1,34 @@
>>>> +#!/bin/sh
>>>> +# SPDX-License-Identifier: GPL-2.0
>>>> +
>>>> +PKG="ncursesw menuw panelw"
>>>> +PKG2="ncurses menu panel"
>>>> +
>>>> +if pkg-config --exists $PKG; then
>>>> +     echo libs=\"$(pkg-config --libs $PKG)\"
>>>> +     exit 0
>>>> +fi
>>>> +
>>>> +if pkg-config --exists $PKG2; then
>>>> +     echo libs=\"$(pkg-config --libs $PKG2)\"
>>>> +     exit 0
>>>> +fi
>>>> +
>>>
>>> I guess this one needs clags, especially -I, like the mconf patch contains...
>>
>>
>>
>> I thought so.
>>
>> But, the current scripts/kconfig/Makefile
>> adds 'pkg-config --libs' to nconf,
>> but does nothing about 'pkg-config --cflags' for nconf.
>> Therefore, I kept the current behavior just in case.
>>
>>
>> The nconfig in the current version is not working for you, right?
>
> That's correct.
>
>
> Info:
>
> $ make ARCH=x86_64 O=xx64 nconfig
> make[1]: Entering directory '/home/rdunlap/lnx/next/linux-next-20180517/xx64'
>   GEN     ./Makefile
>   UPD     scripts/kconfig/.nconf-cfg
>   HOSTCC  scripts/kconfig/nconf.o
> In file included from ../scripts/kconfig/nconf.c:15:0:
> ../scripts/kconfig/nconf.h:19:18: fatal error: menu.h: No such file or directory
>  #include <menu.h>
>                   ^
> compilation terminated.
> scripts/Makefile.host:107: recipe for target 'scripts/kconfig/nconf.o' failed
> make[2]: *** [scripts/kconfig/nconf.o] Error 1
> /home/rdunlap/lnx/next/linux-next-20180517/Makefile:525: recipe for target 'nconfig' failed
> make[1]: *** [nconfig] Error 2
> make[1]: Leaving directory '/home/rdunlap/lnx/next/linux-next-20180517/xx64'
> Makefile:146: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
>
>
> xx64/scripts/kconfig/.nconf-cfg contains:
> libs="-lncursesw -lmenuw -lpanelw"
>

Sorry, I mean
the nconfig in the Linus tree is not working, right?



-- 
Best Regards
Masahiro Yamada