linux-kernel - Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATr+qHfjpYaj2h2-AcMUFozeyRDETjtJcp4kd8=DEk5dw@mail.gmail.com>
Date:   Mon, 21 May 2018 14:38:48 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Ulf Magnusson <ulfalizer@...il.com>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nicholas Piggin <npiggin@...il.com>,
        Kees Cook <keescook@...omium.org>,
        Emese Revfy <re.emese@...il.com>, X86 ML <x86@...nel.org>
Subject: Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu
 after yyparse()

2018-05-20 23:39 GMT+09:00 Sam Ravnborg <sam@...nborg.org>:

>> @@ -544,10 +530,10 @@ void conf_parse(const char *name)
>>       if (!modules_sym)
>>               modules_sym = sym_find( "n" );
>>
>> -     tmp = rootmenu.prompt->text;
>> -     rootmenu.prompt->text = _(rootmenu.prompt->text);
>> -     rootmenu.prompt->text = sym_expand_string_value(rootmenu.prompt->text);
>> -     free((char*)tmp);
>> +     if (!menu_has_prompt(&rootmenu)) {
>> +             current_entry = &rootmenu;
>> +             menu_add_prompt(P_MENU, "Linux Kernel Configuration", NULL);
>
> Could this be something less specific?
> To help the other users of kconfig out is the wild.
>
> For example:
>
>         menu_add_prompt(P_MENU, _("Main menu"), NULL);


OK, but this should be done as a separate work.

I am keeping the current string "Linux Kernel Configuration"



> Note, the added _() to make the text translateable.
>

Hmm, I just wonder how much helpful gettext things are...

Rather, it looks maintenance burden to me.
Once we add messages, it is difficult to change.


-- 
Best Regards
Masahiro Yamada