[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAAa=b7f3LA4GS18VfLouDLFYAsGifwbWb1DtMeWSGOCT64egug@mail.gmail.com>
Date: Mon, 21 May 2018 01:48:31 -0500
From: Wenwen Wang <wang6495@....edu>
To: David Miller <davem@...emloft.net>
Cc: Kangjie Lu <kjlu@....edu>, Armin Schindler <mac@...ware.de>,
Karsten Keil <isdn@...ux-pingi.de>,
"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>,
Wenwen Wang <wang6495@....edu>
Subject: Re: [PATCH v2] isdn: eicon: fix a missing-check bug
On Sun, May 20, 2018 at 5:37 PM, David Miller <davem@...emloft.net> wrote:
> From: Wenwen Wang <wang6495@....edu>
> Date: Fri, 18 May 2018 16:33:47 -0500
>
>> In divasmain.c, the function divas_write() firstly invokes the function
>> diva_xdi_open_adapter() to open the adapter that matches with the adapter
>> number provided by the user, and then invokes the function diva_xdi_write()
>> to perform the write operation using the matched adapter. The two functions
>> diva_xdi_open_adapter() and diva_xdi_write() are located in diva.c.
>
> This doesn't even compile:
>
> In file included from drivers/isdn/hardware/eicon/divasmain.c:30:
> drivers/isdn/hardware/eicon/diva.h:23:18: error: unknown type name ‘diva_xdi_um_cfg_cmd_t’
> int length, diva_xdi_um_cfg_cmd_t *msg,
> ^~~~~~~~~~~~~~~~~~~~~
> drivers/isdn/hardware/eicon/diva.h:27:20: error: unknown type name ‘diva_xdi_um_cfg_cmd_t’
> int length, diva_xdi_um_cfg_cmd_t *msg,
> ^~~~~~~~~~~~~~~~~~~~~
Sorry. I will correct the compilation errors and resubmit the patch.
Wenwen
Powered by blists - more mailing lists