[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAPDyKFpr6TzDDJA3gaczGzv+5xjjvhqPB1rqL86G4Dmw2xHeXg@mail.gmail.com>
Date: Mon, 21 May 2018 13:37:06 +0200
From: Ulf Hansson <ulf.hansson@...aro.org>
To: Scott Branden <scott.branden@...adcom.com>
Cc: Adrian Hunter <adrian.hunter@...el.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@...adcom.com>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Corneliu Doban <corneliu.doban@...adcom.com>
Subject: Re: [PATCH 3/3] mmc: sdhci-iproc: add SDHCI_QUIRK2_HOST_OFF_CARD_ON
for cygnus
On 19 May 2018 at 00:03, Scott Branden <scott.branden@...adcom.com> wrote:
> From: Corneliu Doban <corneliu.doban@...adcom.com>
>
> The SDHCI_QUIRK2_HOST_OFF_CARD_ON is needed for the driver to
> properly reset the host controller (reset all) on initialization
> after exiting deep sleep.
>
> Signed-off-by: Corneliu Doban <corneliu.doban@...adcom.com>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> Reviewed-by: Ray Jui <ray.jui@...adcom.com>
> Reviewed-by: Srinath Mannam <srinath.mannam@...adcom.com>
Applied for fixes, by adding a fixes+stable tag, thanks!
Fixes: c833e92bbb60 ("mmc: sdhci-iproc: support standard byte
register accesses")
Cc: stable@...r.kernel.org # v4.10+
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci-iproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
> index 1f0ab08..d0e83db 100644
> --- a/drivers/mmc/host/sdhci-iproc.c
> +++ b/drivers/mmc/host/sdhci-iproc.c
> @@ -186,7 +186,7 @@ static const struct sdhci_ops sdhci_iproc_32only_ops = {
>
> static const struct sdhci_pltfm_data sdhci_iproc_cygnus_pltfm_data = {
> .quirks = SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK,
> - .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN,
> + .quirks2 = SDHCI_QUIRK2_ACMD23_BROKEN | SDHCI_QUIRK2_HOST_OFF_CARD_ON,
> .ops = &sdhci_iproc_32only_ops,
> };
>
> --
> 2.5.0
>
Powered by blists - more mailing lists