linux-kernel - Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its highest bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d73f1b8-453a-fcbe-a1b8-41ced652deb0@gmail.com>
Date:   Mon, 21 May 2018 08:19:20 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Michal Vokáč <vokac.m@...il.com>,
        netdev@...r.kernel.org, michal.vokac@...ft.com
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        vivien.didelot@...oirfairelinux.com, andrew@...n.ch,
        mark.rutland@....com, robh+dt@...nel.org, davem@...emloft.net
Subject: Re: [PATCH net-next 4/7] net: dsa: qca8k: Force CPU port to its
 highest bandwidth



On 05/21/2018 06:28 AM, Michal Vokáč wrote:
> By default autonegotiation is enabled to configure MAC on all ports.
> For the CPU port autonegotiation can not be used so we need to set
> some sensible defaults manually.
> 
> This patch forces the default setting of the CPU port to 1000Mbps/full
> duplex which is the chip maximum capability.
> 
> Also correct size of the bit field used to configure link speed.
> 
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Likewise, would not we want to have a:

Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")

tag here as well?
-- 
Florian