[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180521161443.GA9998@jamesdev>
Date: Mon, 21 May 2018 17:14:45 +0100
From: James Hogan <jhogan@...nel.org>
To: Matt Redfearn <matt.redfearn@...s.com>
Cc: Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] MIPS: memset.S: Add comments to fault fixup
handlers
On Tue, Apr 17, 2018 at 04:40:03PM +0100, Matt Redfearn wrote:
> diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S
> index 1cc306520a55..a06dabe99d4b 100644
> --- a/arch/mips/lib/memset.S
> +++ b/arch/mips/lib/memset.S
> @@ -231,16 +231,25 @@
>
> #ifdef CONFIG_CPU_MIPSR6
> .Lbyte_fixup\@:
> + /*
> + * unset_bytes = current_addr + 1
> + * a2 = t0 + 1
The code looks more like a2 = 1 - t0 to me:
> + */
> PTR_SUBU a2, $0, t0
> jr ra
> PTR_ADDIU a2, 1
I.e. t0 counts up to 1 and then stops.
Anyway I've applied patch 3 for 4.18.
Cheers
James
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists