linux-kernel - Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180521163932.GA12779@jamesdev>
Date:   Mon, 21 May 2018 17:39:33 +0100
From:   James Hogan <jhogan@...nel.org>
To:     Mathias Kresin <dev@...sin.me>
Cc:     john@...ozen.org, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org, martin.blumenstingl@...glemail.com,
        hauke@...ke-m.de, stable@...r.kernel.org
Subject: Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts

On Sun, Apr 08, 2018 at 10:30:03AM +0200, Mathias Kresin wrote:
> While doing a global software reset, these bits are not cleared and let
> some bootloader fail to initialise the GPHYs. The bootloader don't
> expect the GPHYs in reset, as they aren't during power on.
> 
> The asserts were a workaround for a wrong syscon-reboot mask. With a
> mask set which includes the GPHY resets, these resets aren't required
> any more.
> 
> Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU syscon-mfd")
> Cc: stable@...r.kernel.org # 4.14+
> Signed-off-by: Mathias Kresin <dev@...sin.me>

Applied for 4.17. Thanks for the acks/reviews folk!

Thanks
James

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)