linux-kernel - Re: mmotm 2018-05-17-16-26 uploaded (autofs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11712bc6-9d45-7bb1-4e88-720ee3e312dd@themaw.net>
Date:   Mon, 21 May 2018 08:49:08 +0800
From:   Ian Kent <raven@...maw.net>
To:     Randy Dunlap <rdunlap@...radead.org>, akpm@...ux-foundation.org,
        broonie@...nel.org, mhocko@...e.cz, sfr@...b.auug.org.au,
        linux-next@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        mm-commits@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>
Subject: Re: mmotm 2018-05-17-16-26 uploaded (autofs)

On 21/05/18 08:43, Ian Kent wrote:
>>>
>>> It looks like adding:
>>> depends on AUTOFS_FS = n && AUTOFS_FS != m
>>
>> Hi.  Is there a typo on the line above?

LOL, but your point is what does the AUTOFS_FS != m do!

The answer should be nothing but ..... I'll have to play
a little more.

> 
> Don't think so.
> 
> This was straight out of:
> 
> diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
> index 53bc592a250d..2f9bafabac1b 100644
> --- a/fs/autofs4/Kconfig
> +++ b/fs/autofs4/Kconfig
> @@ -1,6 +1,7 @@
>  config AUTOFS4_FS
>         tristate "Kernel automounter version 4 support (also supports v3 and v5)"
>         default n
> +       depends on AUTOFS_FS = n && AUTOFS_FS != m
>         help
>           The automounter is a tool to automatically mount remote file systems
>           on demand. This implementation is partially kernel-based to reduce
> @@ -30,3 +31,10 @@ config AUTOFS4_FS
>           - any "alias autofs autofs4" will need to be removed.
>  
>           Please configure AUTOFS_FS instead of AUTOFS4_FS from now on.
> +
> +         NOTE: Since the modules autofs and autofs4 use the same file system
> +               type name of "autofs" only one can be built. The "depends"
> +               above will result in AUTOFS4_FS not appearing in .config for
> +               any setting of AUTOFS_FS other than n and AUTOFS4_FS will
> +               appear under the AUTOFS_FS entry otherwise which is intended
> +               to draw attention to the module rename change.
> 
> which appears to do what's needed about as well as can be done and deals
> with the AUTOFS4_FS=y && AUTOFS_FS=y case.
> 
> Ian
>