linux-kernel - Re: [v4 09/11] drivers/hwmon: Add PECI cputemp driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 May 2018 23:01:58 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jae Hyun Yoo <jae.hyun.yoo@...ux.intel.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Jean Delvare <jdelvare@...e.com>,
        Jason M Biils <jason.m.bills@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Alan Cox <alan@...ux.intel.com>,
        Andrew Jeffery <andrew@...id.au>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Arnd Bergmann <arnd@...db.de>, Joel Stanley <joel@....id.au>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        Stef van Os <stef.van.os@...drive-technologies.com>
Subject: Re: [v4 09/11] drivers/hwmon: Add PECI cputemp driver

> >>+#if IS_ENABLED(CONFIG_X86)
> >>+#include <asm/intel-family.h>
> >>+#else
> >>+#define INTEL_FAM6_HASWELL_X   0x3F
> >>+#define INTEL_FAM6_BROADWELL_X 0x4F
> >>+#define INTEL_FAM6_SKYLAKE_X   0x55
> >>+#endif
> >
> >The entire code is very Intel specific. Why this #if instead of
> >making the driver dependent on X86 ?
> >
> 
> This code will be running on ARM kernel at this moment with a purpose
> of monitoring remote x86 CPUs through PECI connection

How about moving what you need from asm/intel-family.h into a header
file in include/linux/. Or move the entire header?

     Andrew