Subject: Fwd: Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE From: Karthik Ramasubramanian Date: 5/21/2018 10:44 AM To: "Mahadevan, Girish" -------- Forwarded Message -------- Subject: Re: [PATCH v3 1/4] dt-bindings: soc: qcom: Add device tree binding for GENI SE Date: Tue, 6 Mar 2018 10:13:09 -0700 From: Karthik Ramasubramanian To: Rob Herring CC: Jonathan Corbet , Andy Gross , David Brown , Mark Rutland , Wolfram Sang , Greg Kroah-Hartman , linux-doc@vger.kernel.org, linux-arm-msm , devicetree@vger.kernel.org, Linux I2C , linux-serial@vger.kernel.org, Jiri Slaby , evgreen@chromium.org, acourbot@chromium.org, Sagar Dharia , Girish Mahadevan On 3/6/2018 6:22 AM, Rob Herring wrote: > > On Mon, Mar 5, 2018 at 6:55 PM, Karthik Ramasubramanian > > wrote: >> >> >> >> >> >> On 3/5/2018 4:58 PM, Rob Herring wrote: >>> >>> >>> >>> On Tue, Feb 27, 2018 at 06:38:06PM -0700, Karthikeyan Ramasubramanian >>> >>> wrote: >>>> >>>> >>>> >>>> Add device tree binding support for the QCOM GENI SE driver. >>>> >>>> >>>> >>>> Signed-off-by: Karthikeyan Ramasubramanian >>>> >>>> Signed-off-by: Sagar Dharia >>>> >>>> Signed-off-by: Girish Mahadevan >>>> >>>> --- >>>> >>>> .../devicetree/bindings/soc/qcom/qcom,geni-se.txt | 89 >>>> >>>> ++++++++++++++++++++++ >>>> >>>> 1 file changed, 89 insertions(+) >>>> >>>> create mode 100644 >>>> >>>> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt >>>> >>>> >>>> >>>> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt >>>> >>>> b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt >>>> >>>> new file mode 100644 >>>> >>>> index 0000000..fe6a0c0 >>>> >>>> --- /dev/null >>>> >>>> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt >>>> >>>> @@ -0,0 +1,89 @@ >>>> >>>> +Qualcomm Technologies, Inc. GENI Serial Engine QUP Wrapper Controller >>>> >>>> + >>>> >>>> +Generic Interface (GENI) based Qualcomm Universal Peripheral (QUP) >>>> >>>> wrapper >>>> >>>> +is a programmable module for supporting a wide range of serial >>>> >>>> interfaces >>>> >>>> +like UART, SPI, I2C, I3C, etc. A single QUP module can provide upto 8 >>>> >>>> Serial >>>> >>>> +Interfaces, using its internal Serial Engines. The GENI Serial Engine >>>> >>>> QUP >>>> >>>> +Wrapper controller is modeled as a node with zero or more child nodes >>>> >>>> each >>>> >>>> +representing a serial engine. >>>> >>>> + >>>> >>>> +Required properties: >>>> >>>> +- compatible: Must be "qcom,geni-se-qup". >>>> >>>> +- reg: Must contain QUP register address and length. >>>> >>>> +- clock-names: Must contain "m-ahb" and "s-ahb". >>>> >>>> +- clocks: AHB clocks needed by the device. >>>> >>>> + >>>> >>>> +Required properties if child node exists: >>>> >>>> +- #address-cells: Must be <1> for Serial Engine Address >>>> >>>> +- #size-cells: Must be <1> for Serial Engine Address >>>> >>>> Size >>>> >>>> +- ranges: Must be present >>>> >>>> + >>>> >>>> +Properties for children: >>>> >>>> + >>>> >>>> +A GENI based QUP wrapper controller node can contain 0 or more child >>>> >>>> nodes >>>> >>>> +representing serial devices. These serial devices can be a QCOM UART, >>>> >>>> I2C >>>> >>>> +controller, spi controller, or some combination of aforementioned >>>> >>>> devices. >>> >>> >>> >>> >>> >>> s/spi/SPI/ >>> >>> >>> >>> Where's the SPI binding? >> >> >> >> Since the patch series introduces UART and I2C drivers, I added the bindings >> >> only for them. I thought about adding the SPI binding when the SPI >> >> controller driver is introduced. Please let me know if you want me to add >> >> the bindings for SPI in this patch series itself. > > > > There's no requirement to have the driver and I prefer bindings be as > > complete as possible. Ok, I will add the bindings for SPI controller in the next posting. > > > > Rob > > Regards, Karthik. -- Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project