[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180522200950.GA16392@rob-hp-laptop>
Date: Tue, 22 May 2018 15:09:50 -0500
From: Rob Herring <robh@...nel.org>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: Icenowy Zheng <icenowy@...c.io>,
Mark Rutland <mark.rutland@....com>,
Maxime Ripard <maxime.ripard@...tlin.com>,
Chen-Yu Tsai <wens@...e.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Kishon Vijay Abraham I <kishon@...com>,
Felipe Balbi <balbi@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org, linux-sunxi@...glegroups.com
Subject: Re: [PATCH 4/5] arm64: allwinner: h6: add USB3 device nodes
On Tue, May 08, 2018 at 11:31:27AM +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 5/7/2018 6:18 PM, Icenowy Zheng wrote:
>
> > Allwinner H6 SoC features USB3 functionality, with a DWC3 controller and
> > a custom PHY.
> >
> > Add device tree nodes for them.
> >
> > Signed-off-by: Icenowy Zheng <icenowy@...c.io>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 38 ++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > index c72da8cd9ef5..9564c938717c 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi
> > @@ -174,6 +174,44 @@
> > status = "disabled";
> > };
> > + usb3: usb@...0000 {
>
> I don't think <unit-address> is allowed for a node having no "reg" prop...
Right. One way to fix is fill out ranges property because the unit
address can come from either.
However, there's work to deprecate doing DWC3 binding with a child node
like this. See the series "usb: dwc3: support clocks and resets for DWC3
core". Please follow that.
Rob
Powered by blists - more mailing lists