linux-kernel - Re: [PATCH v8 2/2] leds: lm3601x: Introduce the lm3601x LED driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6577f2f9-7a31-3b98-71e2-2f86818eac7a@gmail.com>
Date:   Tue, 22 May 2018 22:58:12 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Dan Murphy <dmurphy@...com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>
Subject: Re: [PATCH v8 2/2] leds: lm3601x: Introduce the lm3601x LED driver

On 05/22/2018 10:34 PM, Andy Shevchenko wrote:
> On Tue, May 22, 2018 at 11:26 PM, Dan Murphy <dmurphy@...com> wrote:
>> On 05/22/2018 03:12 PM, Andy Shevchenko wrote:
>>> On Tue, May 22, 2018 at 5:24 PM, Dan Murphy <dmurphy@...com> wrote:
> 
> 
>>>> +static struct lm3601x_led *fled_cdev_to_led(
>>>> +                               struct led_classdev_flash *fled_cdev)
>>>
>>> Didn't notice before. This will look much better in one line.
>>
>> Gives LTL warning.
> 
> I wouldn't really care about it.
> But I leave to Jacek to decide.

Please make it one line.

It is even Linus' recommendation to not strictly stick to the
80 character limit as we all have modern computers nowadays.

> After addressing the rest, FWIW,
> 
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 

-- 
Best regards,
Jacek Anaszewski