linux-kernel - Re: [PATCH V4 13/38] x86/intel_rdt: Introduce "bit_usage" to display cache allocations details

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <949cb2bb-a5b2-3287-acaf-48a0fd53df87@intel.com>
Date:   Tue, 22 May 2018 14:09:47 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>, tglx@...utronix.de,
        fenghua.yu@...el.com, tony.luck@...el.com,
        vikas.shivappa@...ux.intel.com
Cc:     gavin.hindman@...el.com, jithu.joseph@...el.com,
        dave.hansen@...el.com, mingo@...hat.com, hpa@...or.com,
        x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 13/38] x86/intel_rdt: Introduce "bit_usage" to display
 cache allocations details

Hi Randy,

On 5/22/2018 2:03 PM, Randy Dunlap wrote:
> On 05/22/2018 04:29 AM, Reinette Chatre wrote:
>> With cache regions now explicitly marked as "shareable" or "exclusive"
>> we would like to communicate to the user how portions of the cache
>> are used.
>>
>> Introduce "bit_usage" that indicates for each resource
>> how portions of the cache are configured to be used.
>>
>> To assist the user to distinguish whether the sharing is from software or
>> hardware we add the following annotation:
>>
>> 0 - currently unused
>> X - currently available for sharing and used by software and hardware
>> H - currently used by hardware only but available for software use
>> S - currently used and shareable by software only
>> E - currently used exclusively by one resource group
>>
>> Signed-off-by: Reinette Chatre <reinette.chatre@...el.com>
>> ---
>>  arch/x86/kernel/cpu/intel_rdt_rdtgroup.c | 79 ++++++++++++++++++++++++++++++++
>>  1 file changed, 79 insertions(+)
>>
> 
> Hi,
> 
> All occurrences of seq_puts(f, one_char_string); should instead be
> seq_putc(f, one_char);
> 
> Same for patch 14.

Thank you very much for catching this. Will do.

Reinette