linux-kernel - Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing up a port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42a8bf22-6def-bfdd-02fb-ab1112ee3c50@gmail.com>
Date:   Tue, 22 May 2018 07:28:40 +0200
From:   Michal Vokáč <vokac.m@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>, netdev@...r.kernel.org
Cc:     michal.vokac@...ft.com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
        andrew@...n.ch, mark.rutland@....com, robh+dt@...nel.org,
        davem@...emloft.net
Subject: Re: [PATCH net-next 3/7] net: dsa: qca8k: Enable RXMAC when bringing
 up a port

On 21.5.2018 17:17, Florian Fainelli wrote:
> 
> On 05/21/2018 06:28 AM, Michal Vokáč wrote:
>> When a port is brought up/down do not enable/disable only the TXMAC
>> but the RXMAC as well. This is essential for the CPU port to work.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> 
> Should this have:
> 
> Fixes: 6b93fb46480a ("net-next: dsa: add new driver for qca8xxx family")?

Yes, I think it is a good idea to can add this. Will do it in v2.

Thanks,
Michal