[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <FFF73D592F13FD46B8700F0A279B802F392AE61C@ORSMSX114.amr.corp.intel.com>
Date: Tue, 22 May 2018 22:44:46 +0000
From: "Prakhya, Sai Praneeth" <sai.praneeth.prakhya@...el.com>
To: Peter Zijlstra <peterz@...radead.org>
CC: "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Lee Chun-Yi <jlee@...e.com>, Borislav Petkov <bp@...en8.de>,
"Luck, Tony" <tony.luck@...el.com>,
Will Deacon <will.deacon@....com>,
"Hansen, Dave" <dave.hansen@...el.com>,
Mark Rutland <mark.rutland@....com>,
Bhupesh Sharma <bhsharma@...hat.com>,
Naresh Bhat <naresh.bhat@...aro.org>,
"Neri, Ricardo" <ricardo.neri@...el.com>,
"Shankar, Ravi V" <ravi.v.shankar@...el.com>,
"Matt Fleming" <matt@...eblueprint.co.uk>,
"Williams, Dan J" <dan.j.williams@...el.com>,
Ard Biesheuvel <ard.biesheuvel@...aro.org>,
Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Subject: RE: [PATCH V3 2/3] efi: Introduce efi_queue_work() to queue any
efi_runtime_service() on efi_rts_wq
> On Mon, May 21, 2018 at 08:13:03PM -0700, Sai Praneeth Prakhya wrote:
> > + /* \
> > + * queue_work() returns 0 if work was already on queue, \
> > + * _ideally_ this should never happen. \
> > + */ \
> > + if (queue_work(efi_rts_wq, &efi_rts_work.work))
> \
> > + flush_work(&efi_rts_work.work);
> \
>
> Since you're _always_ going to wait for it, it is _much_ cheaper to put a
> completion in your actual work and wait for that.
Sure! I will change it.
I also noticed that flush_work() in turn calls wait_for_completion().
Will also wait for a couple of days before posting V4.
Regards,
Sai
Powered by blists - more mailing lists