[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180522063236.GE7925@lst.de>
Date: Tue, 22 May 2018 08:32:36 +0200
From: Christoph Hellwig <hch@....de>
To: Dan Williams <dan.j.williams@...el.com>
Cc: akpm@...ux-foundation.org, Christoph Hellwig <hch@....de>,
Jérôme Glisse <jglisse@...hat.com>,
Logan Gunthorpe <logang@...tatee.com>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] mm, hmm: mark hmm_devmem_{add, add_resource}
EXPORT_SYMBOL_GPL
On Mon, May 21, 2018 at 03:35:40PM -0700, Dan Williams wrote:
> The routines hmm_devmem_add(), and hmm_devmem_add_resource() are small
> wrappers around devm_memremap_pages(). The devm_memremap_pages()
> interface is a subset of the hmm functionality which has more and deeper
> ties into the kernel memory management implementation. It was an
> oversight that these symbols were not marked EXPORT_SYMBOL_GPL from the
> outset due to how they originally copied (and now reuse)
> devm_memremap_pages().
If we end up keeping this code: absolutely. Then again I think without
an actual user this should have never been merged, and should be removed
until one shows up.
Reviewed-by: Christoph Hellwig <hch@....de>
Powered by blists - more mailing lists