linux-kernel - Re: [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180522082117.p2b5jt5qtuwarqwo@gmail.com>
Date:   Mon, 21 May 2018 22:21:17 -1000
From:   Joey Pabalinas <joeypabalinas@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Joey Pabalinas <joeypabalinas@...il.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>
Subject: Re: [PATCH v4] scripts/tags.sh: use `find` for $ALLSOURCE_ARCHS
 generation

On Tue, May 22, 2018 at 03:01:07PM +0900, Masahiro Yamada wrote:
> The commit log is wrong.
> 
> 
> 2018-05-18 20:56 GMT+09:00 Joey Pabalinas <joeypabalinas@...il.com>:
> > Parsing `ls` is fragile at best and _will_ fail when $tree
> > contains spaces.
> 
> This statement is wrong.
> 
> The cause of the problem is not using whatever command you use,
> but missing quoting.
> The following would work even  if $tree contains spaces:
> 
>     for arch in `ls "${tree}arch"`; do

Ah, to be completely honest that case didn't even occur to me.

> BTW, what was your motivation of this patch?
> 
> Does ${tree} contain spaces?

> 
> If the file path contains spaces, the top Makefile terminates it earlier.
> 
> Makefile:128: *** main directory cannot contain spaces nor colons.  Stop.

It doesn't; I didn't realize the Makefile already had a guard against
spaces in paths. It was something I noticed when poking at something
else and I thought it might be something worth fixing.

But now I agree with you that this patch isn't really needed at all. I can
no longer think of a case where even the original

> for arch in `ls ${tree}arch`; do

would break since spaces are not allowed at all.

Well, on the bright side, the times you happen to be wrong are also the
times where you learn the most :)

-- 
Cheers,
Joey Pabalinas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)