linux-kernel - Re: [PATCH v2 01/15] nls: Wrap uni2char/char2uni callers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180522083753.sphuqufm5edg7dja@quack2.suse.cz>
Date:   Tue, 22 May 2018 10:37:53 +0200
From:   Jan Kara <jack@...e.cz>
To:     Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Cc:     viro@...IV.linux.org.uk, jra@...gle.com, tytso@....edu,
        olaf@....com, darrick.wong@...cle.com,
        kernel@...ts.collabora.co.uk, linux-fsdevel@...r.kernel.org,
        david@...morbit.com, jack@...e.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/15] nls: Wrap uni2char/char2uni callers

On Mon 21-05-18 14:36:03, Gabriel Krisman Bertazi wrote:
> Generated with the following coccinele script:
> 
> <smpl>
> 
> @@
> expression A, B, C, D;
> @@
> (
> - A->uni2char(B, C, D)
> + nls_uni2char(A, B, C, D)
> |
> - A->char2uni(B, C, D)
> + nls_char2uni(A, B, C, D)
> )
> 
> </smpl>
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>

fs/udf/unicode.c also uses char2uni and uni2char but evades your SMPL
patch. So you'll need to fix that up manually. Also note that I have some
changes to that area queued in my tree.

								Honza

-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR