[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180522093806.GA25671@infradead.org>
Date: Tue, 22 May 2018 02:38:06 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Huaisheng Ye <yehs2007@...il.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org, mhocko@...e.com,
willy@...radead.org, vbabka@...e.cz, mgorman@...hsingularity.net,
kstewart@...uxfoundation.org, alexander.levin@...izon.com,
gregkh@...uxfoundation.org, colyli@...e.de, chengnt@...ovo.com,
hehy1@...ovo.com, linux-kernel@...r.kernel.org,
iommu@...ts.linux-foundation.org, xen-devel@...ts.xenproject.org,
linux-btrfs@...r.kernel.org, Huaisheng Ye <yehs1@...ovo.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
Robin Murphy <robin.murphy@....com>
Subject: Re: [RFC PATCH v2 02/12] arch/x86/kernel/amd_gart_64: update usage
of address zone modifiers
This code doesn't exist in current mainline. What kernel version
is your patch against?
On Mon, May 21, 2018 at 11:20:23PM +0800, Huaisheng Ye wrote:
> From: Huaisheng Ye <yehs1@...ovo.com>
>
> Use __GFP_ZONE_MASK to replace (__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32).
>
> ___GFP_DMA, ___GFP_HIGHMEM and ___GFP_DMA32 have been deleted from GFP
> bitmasks, the bottom three bits of GFP mask is reserved for storing
> encoded zone number.
> __GFP_DMA, __GFP_HIGHMEM and __GFP_DMA32 should not be operated by OR.
If they have already been deleted the identifier should not exist
anymore, so either your patch has issues, or at least the description.
Powered by blists - more mailing lists