linux-kernel - Re: set_fs(KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a625c7812378d656d8c7bce65b5222e000ec3a86.camel@kernel.crashing.org>
Date:   Tue, 22 May 2018 22:44:08 +1000
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Al Viro <viro@...IV.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: set_fs(KERNEL_DS) vs iovec

On Tue, 2018-05-22 at 03:20 -0700, Christoph Hellwig wrote:
> On Tue, May 22, 2018 at 03:08:35PM +1000, Benjamin Herrenschmidt wrote:
> > Hence my question: Is is still acceptable these days to use
> > set_fs(KERNEL_DS) for simple cases like this ?
> 
> Not at all.
> 
> > Or is it really
> > deprecated and all new users should use the iovec's ?
> 
> Yes, please use iov_iter.  It should actually make your code simpler,
> too.

In this case it really doesn't :-) But that doesn't matter, I get the
message, I'll fix the driver accordingly.

Cheers,
Ben.